Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

文档更新/Action配置优化/包内README优化 #3618

Merged
merged 67 commits into from
Aug 8, 2023
Merged

Conversation

mamaruo
Copy link
Member

@mamaruo mamaruo commented Aug 4, 2023

因为 #2857 的更改已被回退,故开此 PR。

@boring-cyborg boring-cyborg bot added 1.12.x Minecraft 版本标签 1.16.x Minecraft 版本标签 1.18.x Minecraft 版本标签 1.19.x Minecraft 版本标签 1.20.x Minecraft 版本标签 Fabric 包含 Fabric 模组 Forge 包含 Forge 模组 labels Aug 4, 2023
@cfpa-bot cfpa-bot bot added the config PR 中的更改涉及 Config 文件夹 label Aug 4, 2023
@cfpa-bot
Copy link
Contributor

cfpa-bot bot commented Aug 4, 2023

ℹ 此 PR 没有检测到 CurseForge 模组修改。


💾 基于此 PR 所打包的资源包:



🔛 Diff:


  • 🔄 勾选这个复选框来强制刷新

@cfpa-bot cfpa-bot bot added the 1000+ 行数标签 label Aug 4, 2023
@cfpa-bot cfpa-bot bot removed the config PR 中的更改涉及 Config 文件夹 label Aug 4, 2023
@mamaruo
Copy link
Member Author

mamaruo commented Aug 4, 2023

@dovisutu 我一点没碰 packer 相关文件,也没改过那个所谓征服者模组,为什么 packer 就这样炸了

@dovisutu
Copy link
Contributor

dovisutu commented Aug 8, 2023

  • 现在还会炸吗? 好吧,现在还会炸

是我提packer修改的时候忘记删那个文件的了,然后pr-packer只跑了1.19,于是没炸;我也是在3288里看到炸了才临时删掉那个文件的,反正看起来是空行

打包器现在好像有的流程会莫名其妙被执行两次,然后非文本文件的处理流程跑两次就会炸
之前没炸是正好这些文件全部被丢掉了,所以流程根本没跑
不知道好不好诊断;潜在范围从我的代码一直可能到dotnet库......

把那个conquest-reforged里的minecraft删掉应该就好了(我做了个pr,如果合了需要同步一下分支);还不行可能得稍修一下流程(Add -> TryAdd应该就行);TODO列表+1
(没错,我又没时间了)

@dovisutu dovisutu mentioned this pull request Aug 8, 2023
37 tasks
Delete projects/1.12.2/assets/conquest-reforged/minecraft/lang directory


算是个workaround吧,后续可能还要接着研究
@cfpa-bot cfpa-bot bot added 2000+ 行数标签 and removed 1000+ 行数标签 labels Aug 8, 2023
This reverts commit c049a7c.
@cfpa-bot cfpa-bot bot added the config PR 中的更改涉及 Config 文件夹 label Aug 8, 2023
@cfpa-bot cfpa-bot bot added 1000+ 行数标签 and removed 2000+ 行数标签 labels Aug 8, 2023
@mamaruo mamaruo merged commit 2e6b9b2 into main Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.12.x Minecraft 版本标签 1.16.x Minecraft 版本标签 1.18.x Minecraft 版本标签 1.19.x Minecraft 版本标签 1.20.x Minecraft 版本标签 1000+ 行数标签 config PR 中的更改涉及 Config 文件夹 Fabric 包含 Fabric 模组 Forge 包含 Forge 模组
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants