Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tests #439

Merged
merged 8 commits into from
Jul 30, 2023
Merged

Improved tests #439

merged 8 commits into from
Jul 30, 2023

Conversation

llaniewski
Copy link
Member

This PR introduces improvement in testing:

  • periodic offset option in compare which allows to compare two vti/pvti files with a spatial offset.
  • adding a file (tools/etc/test.exceptions.sh) with test exceptions
  • test for d3q27_pf_velocity (drop on wall)

@llaniewski llaniewski added the tests changed Changes the tests label Jul 30, 2023
@llaniewski llaniewski self-assigned this Jul 30, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2023

Codecov Report

Patch coverage: 97.29% and project coverage change: +1.95% 🎉

Comparison is base (cc4b885) 40.74% compared to head (f5b900d) 42.69%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
+ Coverage    40.74%   42.69%   +1.95%     
===========================================
  Files          157      159       +2     
  Lines         7046     7504     +458     
===========================================
+ Hits          2871     3204     +333     
- Misses        4175     4300     +125     
Flag Coverage Δ
d2q9 30.60% <88.57%> (+0.11%) ⬆️
d2q9_bc 26.90% <88.57%> (+0.12%) ⬆️
d2q9_kuper 27.75% <88.57%> (+0.11%) ⬆️
d3q27_PSM_NEBB 35.66% <97.14%> (+0.14%) ⬆️
d3q27_pf_velocity 30.57% <89.18%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/compare.cpp 96.00% <97.14%> (+1.10%) ⬆️
models/multiphase/d3q27_pf_velocity/Dynamics.c.Rt 61.65% <100.00%> (ø)

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@llaniewski llaniewski merged commit 9a06be7 into develop Jul 30, 2023
@llaniewski llaniewski deleted the tests/twophase branch July 30, 2023 23:22
@llaniewski llaniewski mentioned this pull request Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests changed Changes the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants