Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests FEATURE simple unit test of libyang.h functions #30

Closed
wants to merge 1 commit into from

Conversation

mislavn
Copy link

@mislavn mislavn commented Mar 2, 2016

Signed-off-by: Mislav Novakovic [email protected]

@mislavn
Copy link
Author

mislavn commented Mar 2, 2016

Hi Radek,

I am not sure where to put the used xml file in the unit tests. I used a model from schema/yin/files/a.yin but the used xml file is in data/files/a.xml with other xml files and the unit test is in data/test_libyang.c. Do i need to move the a.xml file or the location of the unit test test_libyang.c?

We will expand this unit test, with the rest of the function from libyang.h and add new unit tests for other functions from headers tree_schema.h, tree_data.h, xml.h and dict.h.

Best regards,
Mislav Novakovic

@rkrejci
Copy link
Collaborator

rkrejci commented Mar 3, 2016

Hi Mislav,
first, thank you for the tests!

So far, the tests/ directory contained perf/ subdir for performance testing (something different from cmocka tests), schema/ for testing schema parsing (e.g. checking schema correctness) and data/ for testing data validation. At least that was the idea about the directory structure. It seems to me that your tests are something different, so maybe there should be added api/ subdir? Anyway, I'm open to suggestions about the tests, so actually anything (even changes of the current structure) that makes some sense is welcome.

Regards,
Radek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants