Skip to content

Fix: missing record.task_id for descendant loggers (e.g. karton.<identity>.module) #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psrok1 merged 1 commit into from
Sep 11, 2025
Merged

Fix: missing record.task_id for descendant loggers (e.g. karton.<identity>.module) #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions karton/core/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,11 @@ def setup_logger(self, level: Optional[Union[str, int]] = None) -> None:
if not self.identity:
raise ValueError("Can't setup logger without identity")

task_context_filter = TaskContextFilter()
self._log_handler.setFormatter(logging.Formatter())
self._log_handler.addFilter(task_context_filter)

logger = logging.getLogger(self.identity)
logger.addFilter(TaskContextFilter())

if logger.handlers:
# If logger already have handlers set: clear them
logger.handlers.clear()
Expand All @@ -148,6 +148,7 @@ def setup_logger(self, level: Optional[Union[str, int]] = None) -> None:
logger.setLevel(log_level)
stream_handler = logging.StreamHandler()
stream_handler.setFormatter(logging.Formatter(self._log_format))
stream_handler.addFilter(task_context_filter)
logger.addHandler(stream_handler)

if not self.debug and self.enable_publish_log:
Expand Down