Fix: MissingContentMD5 due to changed defaults in boto3, added aws_checksum_validation option#289
Closed
Fix: MissingContentMD5 due to changed defaults in boto3, added aws_checksum_validation option#289
Conversation
…ecksum_validation option
Member
Author
|
Unfortunately this still doesn't solve the problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous versions, boto3 was pinned to
<1.36.0due to this problem: boto/boto3#4392. It's better described in #270.Unfortunately it appeared to be still a footgun for us - in v5.8.0 I bumped the boto3 version while adding support for asyncio (#284) and once again hit that problem.
Because CRC64-NVMe checksums are not widely supported across non-AWS S3 providers, it's a bit more safe for us to use different set of defaults than botocore. If someone wants to use defaults proposed by AWS,
[s3].aws_checksum_validationconfiguration option can be set to "1", making it opt-in.