Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openssh upstream's SSH_AUTH_INFO_0 if present #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

opoplawski
Copy link

This seems to make things work on Fedora.

@opoplawski
Copy link
Author

Hmm, maybe this isn't the best approach as SSH_USER_AUTH has a different (though related) function in upstream openssh. Maybe just a way to define the name of the variable?

@Feandil
Copy link
Contributor

Feandil commented Nov 21, 2018

I think that the most forward looking change is to:

  • Rewrite the code (function names/comments/...) to point to SSH_AUTH_INFO_0
  • Replace the hardcoded environment variable name (SSH_AUTH_INFO_0) with a macro/static variable/..., defaulting to SSH_AUTH_INFO_0. On RHEL7, switch that value to SSH_USER_AUTH.

I guess we should also change the name of that pam module...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants