Skip to content

feat(indicator): 方案A全端隐藏下发备注 + 权重列纯数字统一 - #104

Open
muzimu217 wants to merge 1 commit into
developfrom
feat/hide-dispatch-remark
Open

muzimu217 wants to merge 1 commit into
developfrom
feat/hide-dispatch-remark

Conversation

@muzimu217

Copy link
Copy Markdown
Collaborator

方案 A:全端隐藏下发备注字段 + 权重列纯数字统一(用户拍板)

  • 数据库保留 indicator.remark,前端/导入模板/导出/详情全部隐藏(12 文件 +54/-332)
  • 权重列全局统一纯数字格式(去掉「可填 10 / 10% / 0.1」百分比混用;示例值 40%/30% → 40/30/60/40)
  • 1632 用例全绿(四项检查全绿)
  • 上传方式:GitHub Git Data API(blobs→trees→commits→refs,绕过 git 协议 443 阻断)

关联

数据库保留 indicator.remark,前端/导入模板/导出/详情全部隐藏。
权重列全局统一纯数字格式(去掉百分比混用)。
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T12:46:47.912004Z 619ccd2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 619ccd2ae2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

<span class="detail-mutation-after">{{ formatMutationValue(change?.after) }}</span>
</div>
<template v-for="(change, fieldKey) in item.changedFields" :key="fieldKey">
<div v-if="fieldKey !== 'remark'" class="detail-mutation-row">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Filter aggregated remark keys before rendering mutations

When a pending batch contains multiple entities, pendingMutationApprovalItems prefixes each key as <entity> · remark, so this exact equality check misses it and still exposes the supposedly hidden remark values. A single-field remark mutation also leaves an empty “本次异动内容” section because the parent v-if counts the unfiltered keys. Filter based on the normalized field suffix before both the wrapper check and row rendering.

Useful? React with 👍 / 👎.

style="margin-bottom: 16px"
>
学院指标由战略发展部统一下发;本部门负责归口指标的审核进度鉴定与上报审批,并可查看历史数据。
学院指标审批由战略发展部统一组织,本部门仅可查看历史数据

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the functional-department responsibility banner

For functional-department logins, this now says the department can only view history, even though this page still loads the appraisal gate and supports its active appraisal/approval responsibilities. This directly reverts the immediately preceding copy fix and can cause responsible users to overlook work they are expected to perform; retain the wording that describes appraisal and report approval duties.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant