Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WatchServer: Ignore files with size = 0 #9

Closed
SBriere opened this issue Jul 11, 2023 · 2 comments
Closed

WatchServer: Ignore files with size = 0 #9

SBriere opened this issue Jul 11, 2023 · 2 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@SBriere
Copy link
Member

SBriere commented Jul 11, 2023

File with size = 0 should be ignored and put in the "Rejected" folder, since they seem to cause issue with SFTP transfer.

@SBriere SBriere added the bug Something isn't working label Jul 11, 2023
@SBriere SBriere self-assigned this Jul 11, 2023
@SBriere SBriere added the enhancement New feature or request label Jul 11, 2023
@AntoineGuillerand
Copy link
Collaborator

The file seems to be considered as transfered from the watch and will be deleted if the option is checked.
Maybe add a verification on the file size before acknowledging the transfer as done.

SBriere added a commit that referenced this issue Dec 5, 2023
SBriere added a commit that referenced this issue Dec 5, 2023
@SBriere
Copy link
Member Author

SBriere commented Dec 5, 2023

The issue doesn't seem to affect the SFTP transfer in itself (as I tested with 0 byte files without any issue), but might be occurring when the watch transfers its data. I therefore added some checks on file size and replied with an error to the watch if the file size doesn't match the expected content-length or is 0 in size.

@SBriere SBriere closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants