Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow relative file paths #257

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Allow relative file paths #257

merged 2 commits into from
Jan 21, 2025

Conversation

RamiyapriyaS
Copy link
Collaborator

Description

Changes allow for command line parameters to be provided as relative paths.

Checklist

Go Through Checklist Below and Place A ✔️ (X Inside the Box) if Completed

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out? Yes
    • Does it produce the expected outputs, given the inputs provided? Yes

@RamiyapriyaS
Copy link
Collaborator Author

PR Testing:

Run the pipeline with relative paths for the following parameters: meta_path, submission_config, ref_fasta_path, ref_gff_path, and bakta_db_path.

Example command:

nextflow run main.nf -profile test,singularity --species virus --annotation --submission --output_dir rjd0_rel_path --submission_config conf/submission_config.yaml --ref_fasta_path assets/ref/ref.MPXV.NC063383.v7.fasta

@jessicarowell
Copy link
Collaborator

Test data with --virus and --rsv is working, but --bacteria is not. I tried reversing the change to the bacteria annotation subworkflow - no change, so not sure when/how this broke.

nextflow run main.nf -profile singularity,test --species bacteria --output_dir test_alan --submission_config ~/02.scratch/submission_config.yaml --bakta_db_path /scicomp/reference/bakta/db --submission true --submission_wait_time 1 --annotation true --meta_path ~/02.scratch/bacteria_test_metadata_2.xlsx

The metadata path is a custom one where I removed the CP sample because it's giving us issues (see #217).

This is the output:
image

Metadata log says "Metadata validation was successful!"

Copy link
Collaborator

@jessicarowell jessicarowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested --virus and --rsv with test data. Failed for me on a custom bacteria metadata file, but it worked for Ramiya with the test datasets. I'll go ahead and merge because this is probably an issue with my metadata file.

@jessicarowell jessicarowell merged commit 481a9f7 into dev Jan 21, 2025
@jessicarowell jessicarowell deleted the rjd0-relative-paths branch January 21, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Internal] [Bug] 'Not a valid path value:' for relative paths on command line
2 participants