Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing method of file name extraction #253

Merged
merged 2 commits into from
Jan 18, 2025
Merged

Conversation

RamiyapriyaS
Copy link
Collaborator

Description

Changed the method of file name extraction to include everything before "fastq.gz".

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

    For each relevant configuration:

    • Can the program run completely through without erroring out? Yes
    • Does it produce the expected outputs, given the inputs provided? Yes

@RamiyapriyaS
Copy link
Collaborator Author

Method of validation:

  • Test the workflow with samples that include "dots" in the sample name (e.g. sample1.test.R1.fastq.gz, sample1.test.fasta)
  • Test the workflow with existing test data that does not include "dots" in the sample name

@RamiyapriyaS
Copy link
Collaborator Author

Relevant issues: #252 and #173

Copy link
Collaborator

@jessicarowell jessicarowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested virus and also bacteria with annotation. (Did not test virus with annotation though...)
Simplified the getBaseName a bit, seems to accomplish the same thing.

@jessicarowell jessicarowell merged commit c8a5f42 into dev Jan 18, 2025
@jessicarowell jessicarowell deleted the rjd0-dot-changes branch January 18, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants