Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conda fix, schema update, config update #232

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Conda fix, schema update, config update #232

merged 11 commits into from
Dec 16, 2024

Conversation

RamiyapriyaS
Copy link
Collaborator

Description

  • Updated config files to reflect current parameters
  • Added parameter validation through an nf-core plugin
  • Added a nextflow_schema.json file
  • Fixed issues with conda implementation

General Checks

  • Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?

@RamiyapriyaS RamiyapriyaS changed the title Rjd0 testing Conda fix, schema update, config update Dec 12, 2024
This was linked to issues Dec 12, 2024
Bug: Discrepancies in nextflow.config and test.config Files #226
Closed
[Internal] [Bug] Conda environment on scicomp: RepeatMasker::createLib(): Error #216
Closed
[Internal] [Bug] Conda on Scicomp: Issue with cache clearing #224
Closed
[Internal] [Feature] Migrate to nf-core params validation #143
Closed
jessicarowell
jessicarowell reviewed Dec 16, 2024
View reviewed changes
environments/repeatmasker_env_v2.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one? (I'll merge anyway but commenting for future...)

jessicarowell
jessicarowell reviewed Dec 16, 2024
View reviewed changes
environments/vadr_env_v2.yml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this one? (I'll merge anyway but commenting for future...)

@jessicarowell jessicarowell merged commit 03103e9 into dev Dec 16, 2024
@RamiyapriyaS RamiyapriyaS deleted the rjd0-testing branch January 8, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicarowell jessicarowell jessicarowell approved these changes

@yeshtables yeshtables Awaiting requested review from yeshtables

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@RamiyapriyaS @jessicarowell