generated from CDCgov/template
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for custom metadata validation & custom BioSample packages #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Dec 9, 2024
krd7-amd
approved these changes
Dec 17, 2024
krd7-amd
approved these changes
Dec 17, 2024
…ue with .1, .2, etc
…rors out during update_submission
Emergency merging because people are out for the holidays. I may or may not regret this. |
This was
linked to
issues
Dec 18, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remedies the existing custom metadata functionality to correctly populate the submission.xml file with BioSample attributes that are added to input metadata Excel file. It performs a minimal validation on them at this time: it replaces the field name with an (optional) alternative ("new_field_name") and fill empty values with user-specified text ("replace_empty_with").
Changes:
Checklist
General Checks
[] Have you run appropriate tests (unit/integration/end-to-end) to check logic across run environments (Conda/Docker/Singularity on Scicomp/AWS/NF Tower/Local)?
For each relevant configuration:
[] Have you conducted proper linting procedures?
Have you updated existing documentation (README.md, etc.) or created new ones within docs?
CDC Checks
Are additional approvals needed for this change? If so, please mention them below:
Are there potential vulnerabilities or licensing issues with any new dependencies introduced? If so, please mention them below: