Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for python 3.11 #207

Merged
merged 95 commits into from
Jan 12, 2024
Merged

feat: support for python 3.11 #207

merged 95 commits into from
Jan 12, 2024

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Apr 12, 2023

This PR finally adds support for python 3.11 to haptools!

Hopefully, we can get this PR merged before bioconda tries to test our package with 3.11 in January (source).

Note: This PR also upgrades the versions of poetry and python that we use in our development environment. Once this is merged, haptools developers will need to create a new development environment by following the updated directions in the contributing docs.

@aryarm aryarm changed the title add support for python 3.11 feat: support for python 3.11 Apr 12, 2023
@aryarm aryarm changed the title feat: support for python 3.11 feat: support python 3.11 Apr 12, 2023
@aryarm
Copy link
Member Author

aryarm commented Apr 19, 2023

we're currently blocked by cjolowicz/nox-poetry#1116

Otherwise, if we can't find a solution there, we'll have to drop support for python 3.7 in order to support python 3.11

@aryarm aryarm marked this pull request as ready for review December 29, 2023 18:25
@aryarm aryarm changed the title feat: support python 3.11 feat: support for python 3.11 Dec 29, 2023
Copy link
Collaborator

@mlamkin7 mlamkin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question is a comment on the .devcontainer.json file but once completed the rest looks good to me.

@aryarm aryarm merged commit 8e01ed4 into main Jan 12, 2024
11 checks passed
@aryarm aryarm deleted the feat/py311 branch January 12, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants