Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: hidden phasing property in GenotypesPLINK class #153

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Dec 29, 2022

This PR adds tests for a hidden feature in the GenotypesPLINK class: the _prephased property. It can save memory and time when you already know that your genotypes are phased: we won't have to load and check the phase information when reading your genotypes.

I'll take this opportunity to stress that this function should not be used in any real scripts or code! It's just for internal (and theoretical) use. In fact, I'm creating this PR because I think the code doesn't work properly, and I'm trying to reproduce some issues I was having with it.

@aryarm aryarm merged commit a6c32d0 into main Dec 29, 2022
@aryarm aryarm deleted the fix/pgen-prephased branch December 29, 2022 03:49
@aryarm aryarm mentioned this pull request Dec 29, 2022
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant