Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions and publishing releases #117

Open
14 of 15 tasks
aryarm opened this issue Oct 3, 2022 · 1 comment
Open
14 of 15 tasks

github actions and publishing releases #117

aryarm opened this issue Oct 3, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aryarm
Copy link
Member

aryarm commented Oct 3, 2022

It would be nice if we could automate everything!

Some things that our github actions could do

on every pull request, we should...

  • check that we follow the conventional commits spec for that PR title
    so that we can automatically figure out how to bump the version number later on (see for ex, this)
  • run black (and isort?) to check that we follow proper style
  • check that the docs can be built
    but this is already handled by readthedocs, anyway
  • check that large files aren't included in the PR via this github action
  • run pytest to check that...
    • all the tests pass
    • the code coverage doesn't decrease?

every so often, when we want to create a new release, it should...

  • bump the version number
  • build the changelog
  • build the newest release
  • publish it to pypi (and bioconda?)

nox

  • we should install and configure nox to have it run all of our checks
  • incorporate a type checker like mypy?

version constraints

  • we should test our version constraints using nox to ensure they're not being too picky
    • also, do we really need to depend on brewer2mpl? can we find an alternative?
  • and we should remove the upper-limit caps that get added by default by poetry
  • also we should make sure we're configuring our loggers properly (see here, here, and here)

Some relevant links

@aryarm aryarm added the enhancement New feature or request label Oct 3, 2022
@aryarm aryarm changed the title github actions github actions and publishing releases Oct 18, 2022
@aryarm aryarm self-assigned this Nov 18, 2022
@aryarm
Copy link
Member Author

aryarm commented Nov 20, 2022

  • we should also document our process for publishing a new release:
  1. we merge the most recent haptools PR labeled "chore(main)" created by the github actions bot
  2. the bot automatically creates a new version on PyPI and tags a release on Github
  3. bioconda automatically detects the new release on PyPI and creates a PR on their end to have the version updated on bioconda
  4. we have to comment on the PR with "@BiocondaBot please add label"
  5. someone from the bioconda team merges our PR and the version gets updated on bioconda (which usually takes ~1-2 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant