Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following #278, this PR reorganizes the exported BMZ README:
In addition, the API for the BMZ export has changed:
data_description
is now mandatorymodel_version
is an optional parameter allowing to version modelscover
is an optional parameterUsers can now provide a path to a cover, no validation is done of that path. If no cover is provided, then we do something that is probably not optimized for multichannels:
blue
andgreen
Note that that this is not a great way to represent scientific data, we should apply LUT to the grey scale channels and recompose overlays. Look up tables have been worked out for scientific figures and we could use those.
If that is acceptable for now, it will be easy to replace it.
Changes Made
cover_factory.py
Related Issues
#278
#176
Breaking changes
Any call to
careamist.export_bmz
.Additional Notes and Examples
The results README looks like this:
Please ensure your PR meets the following requirements: