Minor feature update #162
Open
Minor feature update #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n just falling back
…s wrong Show filename on MouseHover in TabControl
# Conflicts: # EDSEditorGUI/DeviceODView.Designer.cs # EDSEditorGUI/DeviceODView.cs # libEDSsharp/CanOpenNodeExporter.cs
nimrof
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Looks good, just a few comments and i to me the change here introduces a bug.
If you create a device then remove it save in the menu is not disabled
CANopenEditor/EDSEditorGUI/Form1.Designer.cs
Line 299 in 0c97545
My nitpicking brain may also want to revert the changes in tabControl1_MouseClick as there is no actual change AFIK, but feel free to ignore that
| this.tabControl1.Size = new System.Drawing.Size(1599, 909); | ||
| this.tabControl1.SizeMode = System.Windows.Forms.TabSizeMode.Fixed; | ||
| this.tabControl1.TabIndex = 2; | ||
| this.tabControl1.DrawItem += new System.Windows.Forms.DrawItemEventHandler(this.tabControl1_DrawItem); | ||
| this.tabControl1.ControlAdded += new System.Windows.Forms.ControlEventHandler(this.tabControl1_ControlsChanged); | ||
| this.tabControl1.ControlRemoved += new System.Windows.Forms.ControlEventHandler(this.tabControl1_Controlsremoved); | ||
| this.tabControl1.ControlRemoved += new System.Windows.Forms.ControlEventHandler(this.tabControl1_ControlsChanged); |
There was a problem hiding this comment.
not sure why this is changed, it looks like it is working as it is?
| { | ||
| DeviceView d = (DeviceView)c; | ||
| if (d.eds.Dirty == true) | ||
| { | ||
| page.BackColor = Color.Tomato; | ||
| } | ||
| } |
| @@ -449,13 +462,13 @@ private void Eds_onDataDirty(bool dirty, EDSsharp sender) | |||
| { | |||
| foreach(Control c in page.Controls) | |||
| { | |||
| if(c.GetType() == typeof(DeviceView)) | |||
| if (c.GetType() == typeof(DeviceView)) | |||
There was a problem hiding this comment.
Suggested change
| if (c.GetType() == typeof(DeviceView)) | |
| if(c.GetType() == typeof(DeviceView)) |
| using static System.Windows.Forms.VisualStyles.VisualStyleElement; | ||
| //using static System.Windows.Forms.VisualStyles.VisualStyleElement; | ||
| //using SourceGrid.Cells.Controllers; | ||
| //using ToolTip = System.Windows.Forms.ToolTip; |
There was a problem hiding this comment.
maybe remove the commented code?
| @@ -130,7 +130,7 @@ | |||
| gqUTTxJHNd2gfCHts8Z5i7NeLLN6n/yF4ayxvMR1qkHEsYBFyBChoowNFOEgRrtBio0knUst/AOeXyaX | |||
| Sq4NMHLMowQdiucH/4Pfs7VzE+N+UlgC2l9c92MYCO0CtYrrfh+7bu0ECD4DV0bDX6oC05+kVxpa9Ajo | |||
| 2QYurhuaugdc7gD9T6ZiKZ4UpBJyOeD9jL4pA/TeAp2r/tzq5zh9AFI0q8QNcHAIjOQpe63Fuzua5/bn | |||
| HW9+kH4AMgFyjcd8GS4AAAAJcEhZcwAACw4AAAsOAUC+4UEAAAAHdElNRQfkCwILIglO4xvLAAAAD3RF | |||
| HW9+kH4AMgFyjcd8GS4AAAAJcEhZcwAACwwAAAsMAT9AIsgAAAAHdElNRQfkCwILIglO4xvLAAAAD3RF | |||
There was a problem hiding this comment.
need a little help with the changes here :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add/extend some exception catches to provide more information what was wrong
Show filename on MouseHover in TabControl