Replace Gizmo with CubeGizmo #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remove opacity change
soshochang
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
Hey @soshochang this looks great! Much better than simply fixing the broken gizmo, thanks :) I've pulled your code down and run it and the cube gizmo is working. Just a few nits to sort out, I'll leave some comments. |
av8ta
reviewed
Apr 30, 2024
There was a problem hiding this comment.
@MattFerraro are you happy with me to go ahead and merge this after a few minor things are resolved?
applications/web/src/routes/(CADmium)/CubeGizmo/CubeGizmo.svelte.d.ts
Outdated
Show resolved
Hide resolved
|
Looks great! Yes, after the small changes you requested are in, please go ahead and merge! |
…nts and CubeGizmoSlots from .ts file
|
Done! btw I will be working next on adding some more functionality to this |
|
Merged & live! https://mattferraro.github.io/CADmium/ Thanks again that's a great improvement :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CubeGizmo with cube, xyz axis, and triangle controls.
CubeGizmo orientation matches the orientation of the CAD part
Clicking on a cube face orients the camera to that face
Clicking a triangle arrow rotates the camera