Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up a Cargo workspace for the Rust code #39

Merged
merged 2 commits into from
May 26, 2024

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented May 25, 2024

I'm unsure whether to keep the CADmium.code-workspace file at all. Other than that I think the changes are pretty straight-forward, though the patch and resolver bits of the workspace file probably aren't that obvious (they're needed to match previous semantics).

Regarding resolver specifically, here's what it does: https://doc.rust-lang.org/edition-guide/rust-2021/default-cargo-resolver.html. Explicitly setting the field is required to match what Cargo would have done on the package before (and is also just the more useful behavior).

@av8ta
Copy link
Collaborator

av8ta commented May 25, 2024

Looking at this https://code.visualstudio.com/docs/editor/workspaces it looks like we don't need CADmium.code-workspace as you say. Looks like a hangover from the pre-monorepo setup.

@av8ta
Copy link
Collaborator

av8ta commented May 25, 2024

I tried deleting CADmium.code-workspace and can confirm it's not needed so go ahead and delete that if you like.

@jplatte jplatte force-pushed the cargo-workspace branch from 554fb6e to bb12b3b Compare May 25, 2024 16:06
@av8ta
Copy link
Collaborator

av8ta commented May 26, 2024

Thanks @jplatte!

@av8ta av8ta merged commit c9a2cbe into CADmium-Co:main May 26, 2024
@jplatte jplatte deleted the cargo-workspace branch May 26, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants