Support stablised iter_intersperse #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iter_intersperse was stablised in nightly, meaning we get a conflicting implementation of interspersed. This feels like the easiest way to maintain the functionality while supporting both stable and keeping the path clear for when nightly becomes stable. rust-lang/rust#79524 (comment) rust-lang/rust#88548
|
LGTM! Ping me in a week if I forget to publish this :) bors: r+ |
bors bot
added a commit
that referenced
this pull request
Oct 2, 2021
6: Support stablised iter_intersperse r=CAD97 a=PurpleBooth iter_intersperse was stablised in nightly, meaning we get a conflicting implementation of interspersed. This feels like the easiest way to maintain the functionality while supporting both stable and keeping the path clear for when nightly becomes stable. rust-lang/rust#79524 (comment) rust-lang/rust#88548 Co-authored-by: Billie Thompson <[email protected]>
|
I am participating in hacktoberfest, I'd super appreciate if you could label this issue with |
|
Ah right, that's going on! Thanks for the contribution! This repo is old, and is still hooked up to the dead old Travis rather than GH Actions, so bors is stuck. |
|
Canceled. |
|
Amazing! Thank you, for creating it, it's super useful! |
|
Published as v0.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iter_intersperse was stablised in nightly, meaning we get a conflicting
implementation of interspersed. This feels like the easiest way to
maintain the functionality while supporting both stable and keeping the
path clear for when nightly becomes stable.
rust-lang/rust#79524 (comment)
rust-lang/rust#88548