docs: improve signature malleability wording#153
Merged
Conversation
Update comment to indicate these test vectors should only be used for implementations that _do not_ allow signature malleability. If an implementation tolerates or even requires malleability, it should be tested with a different set of test vectors.
This was referenced Jul 29, 2025
cpu
approved these changes
Jul 29, 2025
Member
cpu
left a comment
cpu
left a comment
There was a problem hiding this comment.
This updated verbiage reads correctly to me as well. Thank you for following up on this upstream :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the churn on this, but while reviewing the downstream PR to integrate #150, I noticed this comment seems incorrect.
I believe it should read something like the following to indicate these test vectors are only for implementations that do not tolerate signature malleability (corroborated by another reviewer here)