Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Drop support for unsupported versions of Node.js #833

Merged
merged 6 commits into from
Dec 27, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,11 @@ module.exports = {
'plugin:jest/recommended',
'plugin:jest/style',
'prettier',
'prettier/@typescript-eslint',
],
ignorePatterns: ['**/build', '**/node_modules', 'documentation'],
rules: {
'@typescript-eslint/no-unsafe-argument': 'off',
'@typescript-eslint/no-unsafe-return': 'warn',
'prettier/prettier': 'error',
'tsdoc/syntax': 'warn',
// never allow default export
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [10.x, 12.x, 14.x, 15.x]
node-version: [18.x, 20.x, 21.x]
steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
60 changes: 0 additions & 60 deletions .github/workflows/whitesource.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v14
v20.10.0
4 changes: 4 additions & 0 deletions documentation/docs/introduction/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@
title: Installation
---

> [!NOTE]
> `fast-csv` only supports the currently supported releases of [nodejs](https://nodejs.org/en/about/releases/).
> You can find the currently supported releases [here](https://endoflife.date/nodejs).

## fast-csv

```sh
Expand Down
2 changes: 1 addition & 1 deletion examples/benchmark/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const promisfyStream = (stream, expectedRows) => {
if (count !== expectedRows) {
rej(new Error(`Error expected ${expectedRows} got ${count}`));
} else {
res();
res(() => {});
}
})
.on('error', rej);
Expand Down
31 changes: 31 additions & 0 deletions examples/example-runner/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/example-runner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"@types/yargs": "16.0.1",
"globby": "11.0.3",
"jest-diff": "26.6.2",
"typescript": "4.0.5",
"typescript": "5.3.3",
"yargs": "16.2.0"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,7 @@ interface UserDetailsRow {
fs.createReadStream(path.resolve(__dirname, '..', 'assets', 'snake_case_users.csv'))
.pipe(csv.parse({ headers: true }))
// pipe the parsed input into a csv formatter
.pipe(
csv.format<UserCsvRow, UserDetailsRow>({ headers: true }),
)
.pipe(csv.format<UserCsvRow, UserDetailsRow>({ headers: true }))
// Using the transform function from the formatting stream
.transform((row, next): void => {
User.findById(+row.id, (err, user) => {
Expand Down
98 changes: 98 additions & 0 deletions examples/fast-csv-ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/fast-csv-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"dependencies": {
"example-runner": "4.3.6",
"fast-csv": "4.3.6",
"typescript": "4.0.5"
"typescript": "5.3.3"
}
}
59 changes: 59 additions & 0 deletions examples/formatting-ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion examples/formatting-ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
"dependencies": {
"@fast-csv/format": "4.3.5",
"example-runner": "4.3.6",
"typescript": "4.0.5"
"typescript": "5.3.3"
}
}
65 changes: 65 additions & 0 deletions examples/parsing-ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading