Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
delete(ps.diffWait, id) while the handshake fails on handler_diff.go
Rationale
The preceding error occurs multiple times when node stop(). Wait channel in waitDiffExtension can't exit normally.
In runEthPeer of eth/handler.go, if the peer has a diff extension, wait for it to connect through peerset.diffWait channel.
While RunPeer of eth/handler_diff.go runs, if the peer.Handshake is successful, peerset.diffWait[id] will exit and be removed. If it it not successful, peerset.diffWait[id] on waitDiffExtension will keep waiting. Which caused graceful shutdown cannot be enabled