-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli supports zset data structures (#249) #310
Conversation
…nd clients to avoid goroutine leaks and reduce the number of goroutines created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution, we will promptly review your code if there are no errors and pass ci. We will merge your pull request into the master branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do not recommend creating consts
files for a zset
, but please add appropriate comments to the file if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid hardcoding strings like 'key' in the codebase,not only for zset other data structures like set,hash, can use for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this, so please add comments to it, for example for zset
data structures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I misunderstood you before. I'll go and modify my code later.
Thank you very much for solving potential security vulnerabilities in FlyDB. After we check that your code is correct, we will merge your pr into the main branch tomorrow. |
1. prevent repeated creation of grpc connections and various command clients to avoid goroutine leaks and reduce the number of goroutines created.
before pr :
flyDB client start
run put test test 11 times
after run put test test 11 times
cause by :
example : string put
after pr :
flyDB client start
run put test test 17 times
after run put test test 17 times
2. cli support zset