Skip to content

[logging] fix: Format count_flops for reusability and correctness - #1003

Merged
FoolPlayer merged 1 commit into
ByteDance-Seed:mainfrom
wyettzeng:mfu_fix
Jul 30, 2026
Merged

FoolPlayer merged 1 commit into
ByteDance-Seed:mainfrom
wyettzeng:mfu_fix

Conversation

@wyettzeng

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Deduplicate dense and MoE Qwen text FLOPs logic across text and VL models.
  • Use explicit config.head_dim for accurate Qwen attention projection sizes.
  • Account for Qwen3.5/Qwen3-Next’s doubled q_proj output for query and output gate.
  • Apply the formatting tool installed in this repo

Checklist Before Starting

  • Search for relative PRs/issues and link here: ...
  • PR title follows [{modules}] {type}: {description} format (enforced by check_pr_title.yml)
    • Allowed modules: agent, ci, ckpt, config, data, dist, docker, docs, logging, lora, misc, model, omni, optim, ops, parallel, perf, release, task, trainer
    • Allowed types: feat, fix, refactor, chore, test
    • Breaking changes: prepend [BREAKING] — e.g. [BREAKING][parallel, model] feat: dynamic batching

Test

Validation results (training curves, eval metrics) for changes not covered by CI.

API and Usage Example

Show API changes and usage examples if applicable.

Design & Code Changes

High-level design description and specific change list.

Checklist Before Submitting

  • Read the Contribute Guide
  • Applied pre-commit checks
  • Added/updated documentation
  • If tasks/ training scripts were moved or renamed: updated docs/ examples and verified python3 scripts/ci/check_doc_task_paths.py passes (also enforced by the Check doc task paths CI workflow)
  • Added tests to CI workflow (or explained why not feasible)

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

@github-actions github-actions Bot added the fix label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants