Improve support for wsl. #33
Conversation
There was a problem hiding this comment.
Thanks a lot for this improvement! To me it looks like without it, open was never really up to the task.
Opening things properly is definitely not as easy as it seemed when I originally wrote this crate.
I have made one suggestion, and will merge this PR once its applied or rejected.
| let path = path.as_ref(); | ||
| let open_handlers = [ | ||
| ("xdg-open", &[path] as &[_]), | ||
| ("gio", &[OsStr::new("open"), path]), |
There was a problem hiding this comment.
Seeing this implies that the previous invocation never worked, which is reflected in its man page.
There was a problem hiding this comment.
gio open works in the old code. The problem is that wsl Ubuntu is not setup with file handlers by default. Ubuntu not under wsl works as expected.
Two devs think this case should never be encountered, so let's put it to the test with `expect()`
|
Unfortunately I made the mistake of fast-forwarding the patch provided here so GitHub doesn't see the merge is completed. I am looking forward to releasing a 2.0 version soon for when correct error handling is made easy. Thanks a lot for all your work thus far! |
The default Ubuntu installation for wsl contains the
giocommand but no applications are registered to handle files. With the current implementationwslviewis never called if another command exists but fails to open the file. This pull request modifiesthat()to loop over every open handler until one reports a successful exit status.To work around a bug in
wslviewthewsl_path()function is introduced to convert an absolute path into a relative path. Ifwslviewfails to find the path, which occurs with absolute paths or non-existent files it erroneously returns a successful exit status.The
whichdependency was removed but thepathdiffdependency was added.