Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yup-oauth2 to 8.3.3 and hyper-rustls to 0.25 #482

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Update yup-oauth2 to 8.3.3 and hyper-rustls to 0.25 #482

merged 2 commits into from
Mar 21, 2024

Conversation

IvanUkhov
Copy link
Contributor

Closes #481.

@IvanUkhov
Copy link
Contributor Author

@Byron, here is an illustration.

@IvanUkhov
Copy link
Contributor Author

OK, it works with unwrapping. But I am not sure if this is appropriate at those places.

Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! It's great this just worked.

The unwraps are acceptable - one is visible in documentation that uses unwraps anyway, the other in the CLI which, I think, aren't used very much.
And even if they are and this fails, the unwrap will make clear enough what happened. If it's a problem, a contribution can fix that issue as well.

Definitely good to go. Please note that I won't create a new release until later this year, so using a vendered version fo the generated code might be the best way to go.

@Byron Byron merged commit cf7f3fa into Byron:main Mar 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support yup-oauth2 v8.3.3 with hyper-rustls v0.25
2 participants