fix(cmn): get cmn compiling on nightly rust #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 18, 2015
|
Thank you ! Now I understand the ticket as well. Maybe I should remove the Cargo.toml, as it doesn't really have a purpose anymore, except for having served for very initial testing. |
Byron
added a commit
that referenced
this pull request
Oct 18, 2015
fix(cmn): get cmn compiling on nightly rust
|
If it's not really used, yeah it probably makes sense to get rid of it, or move it out from the top-level directory. |
|
Just checked it - it's indeed useful for testing the I think I should put it into travis to prevent breakage in future. |
Byron
added a commit
that referenced
this pull request
Nov 8, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131