Remove to_json and add to_string

Byron · Oct 3, 2024 · 8978b94 · 8978b94
1 parent 5a494f3
commit 8978b94
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/google-apis-common/src/lib.rs b/google-apis-common/src/lib.rs
@@ -718,7 +718,11 @@ where
                     let (parts, body) = response.into_parts();
                     let success = parts.status.is_success();
                     let bytes = to_bytes(body).await.unwrap_or_default();
-                    let error = if !success { to_json(&bytes) } else { None };
+                    let error = if !success {
+                        json::from_str(&to_string(&bytes)).ok()
+                    } else {
+                        None
+                    };
                     let response = to_response(parts, bytes);
 
                     if !success {
@@ -776,8 +780,8 @@ where
 }
 
 #[doc(hidden)]
-pub fn to_json(bytes: &hyper::body::Bytes) -> Option<json::Value> {
-    json::from_str(&String::from_utf8_lossy(&bytes)).ok()
+pub fn to_string(bytes: &hyper::body::Bytes) -> std::borrow::Cow<'_, str> {
+    String::from_utf8_lossy(&bytes)
 }
 
 #[doc(hidden)]