64bit dates #892
Merged
64bit dates #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That way, dates beyond 2038 are supported. Further, we rename `Time::seconds_since_unix_epoch` to `seconds`, and remove `seconds()` as there now is a new type, `SecondsSinceUnixEpoch`. In the same vein, we rename `Time::offset_in_seconds` to `offset` as it now has at type `OffsetInSeconds`.
…han {time_in_seconds_since_epoch}` to `seconds`.
This is possible now that there is a type for the time with that name.
Previously we used `usize` which isn't correct on 32 bit systems.
…ate::SecondsSinceUnixEpoch`. After all, these are meant to be the same.
Byron
force-pushed
the
future-dates
branch
4 times, most recently
from
1efd2bb
to
c73b792
Compare
Note that we mention specifically our inability to find a test for https://github.com/git/git/blob/fe86abd7511a9a6862d5706c6fa1d9b57a63ba09/commit-graph.c#L796-L805
Previously, we would always use the commitgraph when available, but now we only do so if the `core.commitGraph` option is set.
…h up to `gix` level. This is merely a debug tool to learn about generation numbers. All commit-graph commands now operate on a repository.
…nerations. This leads to greater correctness of generation numbers when dealing with certain kinds of commit-graphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to git handling far-future commit dates, see test.
Also, we definitely support more than 32 bits for timestamps now.
Tasks
gix-datewith 64 bitcore.commitGraph, mentioncommitGraph.readChangedPaths, and mentioncommitGraph.generationVersioncommit-graph with 64 bit/generation 2 supportThis always worked, even though some numbers can't be represented, we are good for a long time though.support for corrected generation numbers- cannot find a test that truly shows need for this portion of code. Those tests that do don't seem to actually test for it, or test something else. Abandoned for now.