-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prop_cat_cols fails with BOM #227
Comments
This was referenced Jun 19, 2020
BurntSushi
added a commit
that referenced
this issue
Sep 25, 2020
Basically, the problem here is that the quickcheck tests will sometimes generate CSV data that begins with a UTF-8 BOM and the CSV reader automatically strips it. There's a better way to solve this by making tests more robust, but they were written without this consideration. As a hack, we just make sure that we don't generate CSV data that begins with a BOM. This isn't quite 100% correct since we could still get CSV data beginning with a UTF-8 BOM through shrinking, but that only occurs when a legitimate test failure happens. So this could potentially make failure modes worse, but we abide for now. Fixes #227
It looks like this also hits the
|
|
a1165e0 says it fixes this issue, but only exists on a branch, not in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Caught by rustc CI
The test fails when it tries to compare
[[""]]
with[["\u{feff}"]]
. Presumably the BOM is being stripped somewhere.The text was updated successfully, but these errors were encountered: