Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for latest changes with Rust nightly. #5

Closed
wants to merge 1 commit into from

Conversation

kubkon
Copy link

@kubkon kubkon commented Oct 13, 2014

Latest update has modified the CloneableVector trait, and as a result, Vec is no longer an implementor of CloneableVector. To fix this, use AsSlice instead and convert slice/vector to slice, and then call Vec::to_vec() on the result.

I don't know whether this is the best approach as I've only used Rust for a week or so. :-)

Latest update has modified the CloneableVector trait, and as a
result, Vec<T> is no longer an implementor of CloneableVector<T>.
To fix this, use AsSlice<T> instead and convert slice/vector to
slice and then call Vec::to_vec() on the result.
@Proksima
Copy link

Would be nice if this could get pulled, even if temporary before coming with a better solution (if such a solution exists). This is my last dependency on my project that ain't adjusted to the latest rustc build. Eager to run my test-suite on my own project! :)

@BurntSushi
Copy link
Owner

@Proksima rust-lang/rust#17916 (comment)

If you absolutely cannot wait, you should be able to point your Cargo.toml temporarily at @kubkon's fork, right?

@Proksima
Copy link

@BurntSushi Sorry I didn't meant to push you around. Just wanted to show my enthusiasm and eagerness, I appreciate the time you put in this library! [Also, I had another dependency with the same problem, I mixed them up: didn't notice the pull request came in only 2 days ago... Sorry >.<]

You also correctly spotted I am kind of the Git noob, I would have an easier time clonning it, apply the change manually and use that... ^^' No idea how to point to his fork (actually no idea what the url of his fork his, or where to find it).

@Proksima
Copy link

And don't worry about me, it's a personal project. After writing the first comment (to feel less bad about not working), I went on to watch TV. XD

@BurntSushi
Copy link
Owner

@Proksima Haha, OK. No worries. You can get a working build by pointing your Cargo.toml at https://github.com/kubkon/rust-csv. But I'm hoping this is resolved before the end of today.

@Proksima
Copy link

@BurntSushi Oh great! Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants