Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed debug info from release builds #412

Closed
wants to merge 1 commit into from

Conversation

XAMPPRocky
Copy link
Contributor

@XAMPPRocky XAMPPRocky commented Mar 19, 2017

Having debug info enabled on release causes bloated binaries on Unix based systems. This affects people who use cargo install ripgrep.

@BurntSushi
Copy link
Owner

What is the actual problem here? I have debug enabled on release binaries purposefully.

@XAMPPRocky
Copy link
Contributor Author

XAMPPRocky commented Mar 19, 2017

From IRC:

ripgrep's executable is 26MB, 24MB of which is debug information.

This seems a bit much, what is the reasoning for leaving it on in release, profiling?

@BurntSushi
Copy link
Owner

I understand that it makes the binary big. What i would like to know is why that's a problem.

@XAMPPRocky
Copy link
Contributor Author

Other than the inclination to not waste disk space if you don't need to. I think the main problem is the inconsistency as if I was to use one of the package managers using the GitHub releases I would have a binary that is ~1-5MB, whereas with cargo I get 20+MB.

@BurntSushi
Copy link
Owner

@Aaronepower I've moved this discussion to #413 because it really shouldn't be tied to a particular implementation strategy.

@kpp
Copy link
Sponsor Contributor

kpp commented Apr 3, 2017

Well, you can manually strip debug info using strip.

@BurntSushi
Copy link
Owner

I decided to just apply strip in CI, which I did in 30ca3ec

@BurntSushi BurntSushi closed this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants