Make Glob.literal()
a public function
#2946
Open
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to detect if a given string is a glob expression or a literal string is very handy in some contexts.
As on example, we have a list of default AWS regions that we allow the user to specify a glob expression to match. However, the user may want to include another custom string as a region.
Detecting if the user has passed a glob expression or a literal string is currently not possible with this crate, which is a real shame. If
literal()
was public then the implementation above would be as simple as:I think that exposing the full AST or any specific internals is a bad idea, but being able to tell if a glob is a literal string is non-invasive (and simple!) enough to warrant exposing?