Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is yarn.lock really yaml #747

Closed
hoodie opened this issue Jan 13, 2018 · 4 comments
Closed

Is yarn.lock really yaml #747

hoodie opened this issue Jan 13, 2018 · 4 comments
Labels
question An issue that is lacking clarity on one or more points.

Comments

@hoodie
Copy link
Contributor

hoodie commented Jan 13, 2018

hey there
under filetypes DEFAULT_TYPES yarn.lock is listed as yaml. I don't think that is correct.

@BurntSushi
Copy link
Owner

cc @okdana Looks like this got added in 353806b#diff-911d10a397e534d636b0ed516c7d1bc8R271? From looking at yarn.lock files, it does indeed look like it is not yaml?

@BurntSushi BurntSushi added the question An issue that is lacking clarity on one or more points. label Jan 13, 2018
@okdana
Copy link
Contributor

okdana commented Jan 13, 2018

Yeah, you're right. I'd heard tell that it was YAML (see the confusion in this thread for example), and it seemed to be when i glanced at it, but yeah, it's not actually YAML. Sorry :/

I suppose we could add a separate yarn type for it but tbh i doubt many people want to search lock files. I'd only added it because it seemed consistent with Cargo.lock already being in there. I'll just remove it

@BurntSushi
Copy link
Owner

Haha no worries! It actually looked like yaml too when I just glanced at it briefly. Removing it sounds good. :)

okdana added a commit to okdana/ripgrep that referenced this issue Jan 13, 2018
@hoodie
Copy link
Contributor Author

hoodie commented Jan 13, 2018

I actually ran it against two parsers to see if it didn't comply by any obscure yaml rules I wasn't aware of. That wouldn't even have surprised me.

BurntSushi pushed a commit that referenced this issue Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question An issue that is lacking clarity on one or more points.
Projects
None yet
Development

No branches or pull requests

3 participants