Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should the next release be ripgrep 11 or ripgrep 0.11? #1172

Closed
BurntSushi opened this issue Jan 23, 2019 · 4 comments
Closed

should the next release be ripgrep 11 or ripgrep 0.11? #1172

BurntSushi opened this issue Jan 23, 2019 · 4 comments
Labels
question An issue that is lacking clarity on one or more points.

Comments

@BurntSushi
Copy link
Owner

Originally, I had thought that ripgrep would reach 1.0 some day and sit there for a long time with no backwards incompatible changes. In practice, ripgrep has seen very few backwards incompatible changes and no complaints about them thus far as far as I know. Instead of trying to commit to a 1.0 release, I thought it might be nice to just move the minor version over to the major version and subsequently be more flexible about bumping the major version while retaining our fairly conservative policy with regard to backwards incompatible changes.

Thoughts?

@okdana
Copy link
Contributor

okdana commented Jan 23, 2019

So like the major version would just get bumped for each significant new release, similar to how Postgres and Firefox do it, rather than using a semver-style system?

I wouldn't mind it, personally, for whatever that's worth. I don't maintain any projects that rely on ripgrep where semver might be useful, though

@BurntSushi
Copy link
Owner Author

So like the major version would just get bumped for each significant new release, similar to how Postgres and Firefox do it, rather than using a semver-style system?

Pretty much, yes. I would still adhere to semver though. I'd just only do breaking changes in major version releases. Basically, I want to make bumping the major version a normal occurrence. Occasionally there may be a breaking change, but I feel confident breaking changes can be kept very small.

@okdana
Copy link
Contributor

okdana commented Jan 23, 2019

Are you going to change anything about the versioning on the libraries (ignore, grep, &c.), too? Or just ripgrep itself?

@BurntSushi
Copy link
Owner Author

@okdana Ah, no, def not. Just ripgrep itself.

@BurntSushi BurntSushi added the question An issue that is lacking clarity on one or more points. label Jan 24, 2019
BurntSushi added a commit that referenced this issue Apr 14, 2019
This sets up the release announcement and briefly describes the
versioning change. The actual version change itself won't happen until
the release.

Closes #1172
gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Apr 16, 2019
yes, this version jump is not a mistake
Upstream discussion: BurntSushi/ripgrep#1172

Package-Manager: Portage-2.3.62, Repoman-2.3.12
Signed-off-by: Georgy Yakovlev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question An issue that is lacking clarity on one or more points.
Projects
None yet
Development

No branches or pull requests

2 participants