rg --version is misleading #1013
Labels
enhancement
An enhancement to the functionality of the software.
Comments
|
It looks like we'll need to include both compile time and run time support unfortunately. Including only one will be misleading until all of ripgrep's dependencies move to runtime detection. |
BurntSushi
added
the
enhancement
BurntSushi
added a commit
that referenced
this issue
Aug 19, 2018
This commit updates the CHANGELOG to reflect all the work done to make libripgrep a reality. * Closes #162 (libripgrep) * Closes #176 (multiline search) * Closes #188 (opt-in PCRE2 support) * Closes #244 (JSON output) * Closes #416 (Windows CRLF support) * Closes #917 (trim prefix whitespace) * Closes #993 (add --null-data flag) * Closes #997 (--passthru works with --replace) * Fixes #2 (memory maps and context handling work) * Fixes #200 (ripgrep stops when pipe is closed) * Fixes #389 (more intuitive `-w/--word-regexp`) * Fixes #643 (detection of stdin on Windows is better) * Fixes #441, Fixes #690, Fixes #980 (empty matching lines are weird) * Fixes #764 (coalesce color escapes) * Fixes #922 (memory maps failing is no big deal) * Fixes #937 (color escapes no longer used for empty matches) * Fixes #940 (--passthru does not impact exit status) * Fixes #1013 (show runtime CPU features in --version output)
BurntSushi
added a commit
that referenced
this issue
Aug 20, 2018
This commit updates the CHANGELOG to reflect all the work done to make libripgrep a reality. * Closes #162 (libripgrep) * Closes #176 (multiline search) * Closes #188 (opt-in PCRE2 support) * Closes #244 (JSON output) * Closes #416 (Windows CRLF support) * Closes #917 (trim prefix whitespace) * Closes #993 (add --null-data flag) * Closes #997 (--passthru works with --replace) * Fixes #2 (memory maps and context handling work) * Fixes #200 (ripgrep stops when pipe is closed) * Fixes #389 (more intuitive `-w/--word-regexp`) * Fixes #643 (detection of stdin on Windows is better) * Fixes #441, Fixes #690, Fixes #980 (empty matching lines are weird) * Fixes #764 (coalesce color escapes) * Fixes #922 (memory maps failing is no big deal) * Fixes #937 (color escapes no longer used for empty matches) * Fixes #940 (--passthru does not impact exit status) * Fixes #1013 (show runtime CPU features in --version output)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running
rg --versionwith the provided ripgrep-0.9.0-x86_64-unknown-linux-musl binary I'm getting the following output:This suggests that
SIMDandAVXare disabled. However, the binary is supposedly using runtime detection of the corresponding hardware support, so this is misleading.To fix this, the corresponding output code should check for hardware support like the ripgrep code actually using the hardware instructions. Currently, the output code only considers the corresponding Cargo features, ignoring runtime detection.
The text was updated successfully, but these errors were encountered: