apply uppercase flag to compound specifiers #486#488
Merged
BurntSushi merged 1 commit intoBurntSushi:masterfrom Feb 12, 2026
Merged
apply uppercase flag to compound specifiers #486#488BurntSushi merged 1 commit intoBurntSushi:masterfrom
BurntSushi merged 1 commit intoBurntSushi:masterfrom
Conversation
BurntSushi
approved these changes
Feb 12, 2026
Owner
BurntSushi
left a comment
BurntSushi
left a comment
There was a problem hiding this comment.
I'm not a huge fan of this fix, but I don't see another way to do this without semver incompatible changes. I'm especially not a fan because this doesn't fix the %#c case. But I'll take this in and re-evaluate the API here for Jiff 1.0. I created #513 to track that.
BurntSushi
force-pushed
the
fix-strftime-uppercase-compound
branch
from
8b198ed to
8b90983
Compare
Fixes BurntSushi#486, Ref BurntSushi#513 for coming up with a better fix
BurntSushi
force-pushed
the
fix-strftime-uppercase-compound
branch
from
8b90983 to
16858c9
Compare
Owner
|
This PR is on crates.io in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach for #486 checks the extension flag that is passed into the format_* to change the format string if the uppercase flag was set. This was the main approach that I found could be more easily extended for other compound flags.
The overarching purpose of this fix is to use it in uutils coreutils: uutils/coreutils#10242