Merge pull request #12 from ZacharyHampton/proxy_bug

fix: proxy add to session correctly
Bunsly · Sep 19, 2023 · 0a39357 · 0a39357
2 parents 9aaabdd + 8f06d46
commit 0a39357
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/homeharvest/core/scrapers/__init__.py b/homeharvest/core/scrapers/__init__.py
@@ -16,7 +16,14 @@ def __init__(self, scraper_input: ScraperInput):
         self.location = scraper_input.location
         self.listing_type = scraper_input.listing_type
 
-        self.session = requests.Session(proxies=scraper_input.proxy)
+        self.session = requests.Session()
+        if scraper_input.proxy:
+            proxy_url = scraper_input.proxy
+            proxies = {
+                "http": proxy_url,
+                "https": proxy_url
+            }
+            self.session.proxies.update(proxies)
         self.listing_type = scraper_input.listing_type
         self.site_name = scraper_input.site_name
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "homeharvest"
-version = "0.2.4"
+version = "0.2.5"
 description = "Real estate scraping library supporting Zillow, Realtor.com & Redfin."
 authors = ["Zachary Hampton <[email protected]>", "Cullen Watson <[email protected]>"]
 homepage = "https://github.com/ZacharyHampton/HomeHarvest"