ADD possibility to serialize NSNull values (opt-in) eventhough conver… #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter.shouldIgnoreNullValues is set to YES ADD nullability and generics to `JAGPropertyMapping.h` MOD converted `JAGOutputType` to `NS_ENUM` MOD increased minimum deployment target to 7.0 (was 5.0) (otherwise we couldn't use Swift in unit tests)
| @@ -277,16 +283,26 @@ - (NSDictionary*) convertToDictionary: (id) model { | |||
| propertyName = [propertyName asUnderscoreFromCamelCase]; | |||
| } | |||
|
|
|||
| // check if we need to convert nil values into NSNull | |||
| BOOL shouldIgnoreNilValues = self.shouldIgnoreNullValues; | |||
There was a problem hiding this comment.
it's shouldIgnoreNilValue (singular) because it's only for this property
added 4 commits
May 3, 2016 13:42
# Conflicts: # JAGPropertyConverter.xcodeproj/project.pbxproj
…ustom mapping or/and would need snake_case conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converter.shouldIgnoreNullValuesis set toYES. NewJAGPropertyMappingmethod:nilPropertiesNotToIgnoreJAGPropertyMapping.hJAGOutputTypetoNS_ENUMNot sure about the naming of the new protocol method and variables yet. Maybe you have better ideas? :)