Apply metrics in p2p package#433
Closed
trinhdn2 wants to merge 9 commits intoBuildOnViction:masterfrom
trinhdn2:ft/apply_metrics
Closed
Apply metrics in p2p package#433trinhdn2 wants to merge 9 commits intoBuildOnViction:masterfrom trinhdn2:ft/apply_metrics
trinhdn2 wants to merge 9 commits intoBuildOnViction:masterfrom
trinhdn2:ft/apply_metrics
Conversation
added 7 commits
January 15, 2024 15:48
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisite
Checklist
p2p/metricsmetered connection fordiscovermodule. The aim is to have more detailed information about network usage which currently isn't tracked fordiscV4.Added metrics:
discover/bucket/{index}/count- the number of nodes in bucket indexp2p/{ingress|egress}/eth/{version}/{msgCode}- message type level metrics frometh62,eth63p2p/peers- active peer gaugep2p/serves- serve meterp2p/serves/success- serve success meterp2p/dials/success- the total number of dials that result in a peer being added to the peersetp2p/dials/error/connection- unable to initiate TCP connection to targetp2p/dials/error/saturated- local client is already connected to its maximum number of peersp2p/dials/error/known- dialing an already connected peerp2p/dials/error/self- dialing the local node's idp2p/dials/error/useless- dialing a peer that doesn't share an capabilities with the local nodep2p/dials/error/id/unexpected- dialed peer repsoned with different id than expectedp2p/dials/error/rlpx/enc- error negotiating the rlpx encryption during dialp2p/dials/error/rlpx/proto- error during rlpx protocol handshakeExample of new metrics under prometheus format:
References: