Change TxPreEvent to NewTxsEvent#427
Closed
trinhdn2 wants to merge 4 commits intoBuildOnViction:masterfrom
trinhdn2:ft/group_multiple_TxPreEvent
Closed
Change TxPreEvent to NewTxsEvent#427trinhdn2 wants to merge 4 commits intoBuildOnViction:masterfrom trinhdn2:ft/group_multiple_TxPreEvent
trinhdn2 wants to merge 4 commits intoBuildOnViction:masterfrom
trinhdn2:ft/group_multiple_TxPreEvent
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a transaction is promoted, a
TxPreEventwill be pushed to subscribers immediately.While when the number of new transactions received is large, there are too many
TxPreEventwill be pushed leads to txFeed lock resource contention.So in this PR, i replace all
TxPreEventtoNewTxsEvent. So that we can push a batch of new promoted txs together. It will help in these scenario:This works around what seems to be a source of contention when
event.Feed.Sendis called from multiple txpool goroutines at high volume.Besides, this PR also fixes a small problem. When we apply new promoted transaction to mining block, it should still abide original gas limit restriction instead of creating a new gas limit.
Reference: