[TomoX] validate balance#18
Merged
thanhson1085 merged 8 commits intoBuildOnViction:masterfrom Nov 18, 2019
Merged
Conversation
thanhnguyennguyen
force-pushed
the
tomox-validate-balance
branch
from
f9b422c to
54899cb
Compare
thanhnguyennguyen
force-pushed
the
tomox-validate-balance
branch
from
54899cb to
82bf510
Compare
thanhson1085
approved these changes
Nov 18, 2019
nghiatomo
pushed a commit
that referenced
this pull request
Nov 18, 2019
…old-blocks-follow-up Cherry pick #811
thanhson1085
approved these changes
Nov 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8
This PR validates order value with current balance state only, ignoring all balance changes of pending orders in pool and orders which is still opening in orderbooks