Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Lorem Helper validation #15716

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Updates Lorem Helper validation #15716

wants to merge 2 commits into from

Conversation

mikesealey
Copy link
Collaborator

Description

{{ Lorem }} helper will work without a number-perameter and return Lorem ipsum (equivilent to {{ lorem 11 }})

This PR makes a change to the parameter so that the validaiton understand that the number is optional

Please note: This PR contains a 1-line change, and many lint changes.
My work can be found here:
image

Addresses

#15714

Screenshots

Before:
image

After:
image
(No validation warnings)

Launchcontrol

Updates validation on Lorem helper

Copy link

qa-wolf bot commented Mar 11, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

linear bot commented Mar 11, 2025

@mikesealey mikesealey requested a review from adrinr March 11, 2025 12:26
Copy link
Collaborator

@adrinr adrinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is autogenerated, it should come from https://github.com/Budibase/handlebars-helpers
I know that is some tedious extra work, but it would be nice to change it in there and to get it being autogenerated. Otherwise, on the next "update" your changes will be lost.
This would require:

  1. Update the parameter change in https://github.com/Budibase/handlebars-helpers
  2. Merge it to master
  3. Publish a new version (@mike12345567 can help with it)
  4. On this branch, update to use the latest handlebars-helpers package and run yarn manifest from within package/string-templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants