Import OpenAPI fixes #15698
Merged
Import OpenAPI fixes #15698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the issue was related to wrong function being called, would be detected by typing.
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
mike12345567
commented
Mar 7, 2025
| } | ||
|
|
||
| const importResult = await queries.import(body) | ||
| const importResult = await queries.importQueries(body) |
There was a problem hiding this comment.
This is the actual fix, from queries.import -> queries.importQueries
PClmnt
approved these changes
Mar 7, 2025
mike12345567
commented
Mar 7, 2025
There was a problem hiding this comment.
Was duplicated and not used, removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue with the recent Typescript refactors of stores, the
queriesstore used to have an alias forimportwhich is no longer available, converted everything in the area to Typescript and updated to use theimportQueriesfunction instead.Addresses
https://linear.app/budibase/issue/BUDI-9099/rest-api-import-is-broken
#15658