-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Dev #15
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6ec90f3
feat: added 'replyTo' support to chat with auto scrolling and
BuckyMcYolo e832394
feat: added sticky floating date divider to show current message date in
BuckyMcYolo ec6fa79
feat: added attchment uploading and sending via S3 compatible upload
BuckyMcYolo ca3de8e
feat: add file upload toasts, fix auth bypass and reply validation
BuckyMcYolo 1f3d2c5
fix: refactored shared types across packages
BuckyMcYolo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only clear reply mode after a successful send.
onSendis still fire-and-forget, butuseMessageSendingcan return early when the socket or user is unavailable and can roll the optimistic row back on ACK failure inapps/web/src/hooks/use-message-sending.ts, Lines 114-150. Line 580 clearsreplyingToanyway, so a failed send silently exits reply mode and the retry becomes a plain message. HaveonSendresolve a success signal and only callonCancelReplyonce the send actually sticks.🛠️ Proposed fix
interface MessageInputProps { context: ChatContext onSend: ( content: string, options?: { mentions: Message["mentions"] referencedMessage?: Message["referencedMessage"] } - ) => void + ) => Promise<boolean> | boolean isSending?: boolean currentUserId?: string mentionCandidates?: MentionCandidate[] replyingTo?: Message | null onCancelReply?: () => void } @@ - const handleSend = useCallback(() => { + const handleSend = useCallback(async () => { if (!editor) return @@ - onSend(trimmed, { + const didSend = await onSend(trimmed, { mentions, referencedMessage: replyingTo ? { id: replyingTo.id, content: replyingTo.content, author: replyingTo.author, } : undefined, }) + if (!didSend) return editor.commands.clearContent(true) editor.commands.focus("end") setPlainText("") onCancelReply?.() }, [Also applies to: 567-580
🤖 Prompt for AI Agents