Skip to content

fixK remove ioredis from dockerfile deps#30

Merged
BuckyMcYolo merged 1 commit into
mainfrom
dev
Apr 1, 2026
Merged

fixK remove ioredis from dockerfile deps#30
BuckyMcYolo merged 1 commit into
mainfrom
dev

Conversation

@BuckyMcYolo
Copy link
Copy Markdown
Owner

@BuckyMcYolo BuckyMcYolo commented Apr 1, 2026

Summary

This PR updates the tsup bundler configuration for three applications (api, realtime, and worker) to explicitly mark ioredis as an external dependency. This prevents ioredis from being bundled into the build output and instead relies on it being provided by the Node.js runtime from node_modules.

Changes

  • apps/api/tsup.config.ts: Added "ioredis" to the external array alongside existing "dotenv"
  • apps/realtime/tsup.config.ts: Added "ioredis" to the external array
  • apps/worker/tsup.config.ts: Added "ioredis" to the external array

Technical Context

The ioredis dependency is not directly listed in any of these three applications' package.json files but is available transitively through:

  • @repo/auth (direct dependency)
  • bullmq package dependencies (for realtime and worker apps)
  • @socket.io/redis-adapter and @socket.io/redis-emitter (indirect dependencies)

The Dockerfiles for all three applications use pnpm install --frozen-lockfile, which correctly resolves and installs all transitive dependencies, ensuring ioredis will be available at runtime.

Assessment

The bundler configuration change is architecturally sound—marking ioredis as external is a best practice when the dependency will be provided by the runtime environment. This optimization prevents unnecessary code duplication in the bundle while relying on the package manager to ensure correct installation. The change is low-risk with no impact on runtime functionality.

Issues

The PR title references "dockerfile deps" but the actual changes are exclusively in tsup configuration files, not Dockerfiles. The commit message "fixK" lacks clarity about the change's rationale. While these are communication issues rather than functional problems, clearer documentation would improve reviewability.

Confidence Score: 4/5

The PR is technically solid with minimal risk and follows bundler best practices. The slight deduction is due to misleading PR title/commit messaging and lack of explicit rationale documentation. The changes are production-ready with proper supporting infrastructure (pnpm lockfile and monorepo structure) to ensure correct dependency resolution.

@BuckyMcYolo BuckyMcYolo merged commit 4728a57 into main Apr 1, 2026
2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 1, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 816ead7c-9c63-4309-90c3-1a7194ba89e8

📥 Commits

Reviewing files that changed from the base of the PR and between eff453b and 4f5e8ef.

📒 Files selected for processing (3)
  • apps/api/tsup.config.ts
  • apps/realtime/tsup.config.ts
  • apps/worker/tsup.config.ts

📝 Walkthrough

Walkthrough

Updated tsup build configurations across three applications (api, realtime, worker) to externalize the ioredis dependency, preventing it from being bundled into the generated outputs.

Changes

Cohort / File(s) Summary
tsup Build Configuration
apps/api/tsup.config.ts, apps/realtime/tsup.config.ts, apps/worker/tsup.config.ts
Added or updated external array to include ioredis as an external dependency, preventing bundling across all three applications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 Hop hop, the bundler now sees,
ioredis roams wild and free!
No more packed in the box so tight,
External deps make the build light! 🚀

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant