Skip to content

Remove Date and Timestamp from supported types #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
icexelloss wants to merge 1 commit into from
Closed

Remove Date and Timestamp from supported types #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sql/core/src/main/scala/org/apache/spark/sql/ArrowConverters.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,9 @@ private[sql] object ArrowConverters {
case ByteType => new ArrowType.Int(8, true)
case StringType => ArrowType.Utf8.INSTANCE
case BinaryType => ArrowType.Binary.INSTANCE
case DateType => ArrowType.Date.INSTANCE
case TimestampType => new ArrowType.Timestamp(TimeUnit.MILLISECOND)
// TODO: Enable Date and Timestamp type with Arrow 0.3
// case DateType => ArrowType.Date.INSTANCE
// case TimestampType => new ArrowType.Timestamp(TimeUnit.MILLISECOND)
case _ => throw new UnsupportedOperationException(s"Unsupported data type: $dataType")
}
}
Expand Down Expand Up @@ -411,8 +412,9 @@ private[sql] object ColumnWriter {
case ByteType => new ByteColumnWriter(ordinal, allocator)
case StringType => new UTF8StringColumnWriter(ordinal, allocator)
case BinaryType => new BinaryColumnWriter(ordinal, allocator)
case DateType => new DateColumnWriter(ordinal, allocator)
case TimestampType => new TimeStampColumnWriter(ordinal, allocator)
// TODO: Enable Date and Timestamp type with Arrow 0.3
// case DateType => new DateColumnWriter(ordinal, allocator)
// case TimestampType => new TimeStampColumnWriter(ordinal, allocator)
case _ => throw new UnsupportedOperationException(s"Unsupported data type: $dataType")
}
}
Expand Down
2 changes: 1 addition & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/ArrowConvertersSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ class ArrowConvertersSuite extends SharedSQLContext with BeforeAndAfterAll {
collectAndValidate(byteData)
}

test("timestamp conversion") {
ignore("timestamp conversion") {
collectAndValidate(timestampData)
}

Expand Down