feat: switch to d2l-test-runner and new vdiffs #82
Conversation
| "test:headless": "web-test-runner --files \"./test/**/*.test.js\" --node-resolve", | ||
| "test:headless:watch": "web-test-runner --files \"./test/**/*.test.js\" --node-resolve --watch" | ||
| "test": "npm run lint && npm run test:unit", | ||
| "test:unit": "d2l-test-runner" |
There was a problem hiding this comment.
I'd like to rename headless to unit since IMO it's a more meaningful name for these types of tests. If others agree, I can make the change in core as well.
There was a problem hiding this comment.
Sounds good to me, I've never liked headless lol
| @@ -1,5 +1,5 @@ | |||
| import '../<%= hyphenatedName %>.js'; | |||
| import { expect, fixture, html } from '@open-wc/testing'; | |||
| import { expect, fixture, html } from '@brightspace-ui/testing'; | |||
| import { runConstructor } from '@brightspace-ui/core/tools/constructor-test-helper.js'; | |||
There was a problem hiding this comment.
Wondering if this runConstructor should also move into @brightspace-ui/testing... seems weird for it to be in core now that we have our own testing library.
There was a problem hiding this comment.
Oh yeah it should, we talked about that somewhere else but I guess never made a story for it. Won't be able to remove it from core for a long time but might as well get started!
There was a problem hiding this comment.
I've added runConstructor to @brightspace-ui/testing and switched this to use it.
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
No description provided.