Updating vdiff goldens for PR 5164 #5178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
margaree
approved these changes
Nov 27, 2024
margaree
added a commit
that referenced
this pull request
Nov 27, 2024
* feat: Date input: Disclose when data was reverted to previous * add vdiff tests, fix lint * add lang terms * fix click behaviour * code review feedback: use separate concatenated lang terms, get the lang terms on multiple lines, separate out tooltip logic * code review feedback: use one tooltip in _getRevertTooltip * design feedback: include revert info in error tooltip if applicable * Updating vdiff goldens (#5165) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * lang terms: concatenate in lang terms rather than in code * Updating vdiff goldens (#5178) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix accidental lang term changes * add a viewport width to vdiffs * increase timeout on flaky test * try drastically increasing timeout * fix vdiff flake? --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the vdiff goldens for the changes in pull request #5164.
Please review the resulting report closely before merging to ensure the visual differences are expected.